Option for sister moms to node delete job's files sitting on shared location

Here’s the design to introduce a new mom config file option to not delete job’s files sitting on shared location. This is to address the issue when nodes are released early from a job via ‘pbs_release_nodes’, and the job has been submitted with sandbox=PRIVATE, and the $jobdir_root location specified is shared among the primary mom and the sister moms: https://openpbs.atlassian.net/wiki/spaces/PD/pages/1979482121/Option+for+sister+moms+to+not+delete+job+s+files+sitting+on+shared+location

Thanks for explaining the situation. I have a few questions/comments.

$jobdir_root [shared]

Does the “shared” have to be in square brackets [ ]?
What happens if nothing follows the ? Please state the behavior.
Please also add info about what happens if the word following is anything else other than “shared”?

“not cleaned up shared job’s <stageout/execution directory path>”

This read a bit like an error happened…but the behavior is intentional. How about something like “The $jobdir_root location is shared, and will be cleaned up [or you could say “removed”] once the job ends”
Maybe “$jobdir_root” can be replaced by the actual value too…?

The [] was meant to convey that it’s an optional directive, following man page format. One can specify ‘shared’ or not. I’ll make that clearer on the next version.
It’s a good idea to also flag a warning (or error) if something other than ‘shared’ is specified. I’ll add something to the design.

Ok, I’ll improve the message.

It’s a good idea to also flag a warning (or error) if something other than ‘shared’ is specified. I’ll add something to the design.

On second thought, most of the mom config file options with optional directives don’t really check for unrecognized values. An example is “$max_load [suspend]” where it only looks for ‘suspend’ and if it doesn’t find it, just proceed as normal. So I’m treating ‘shared’ the same way. If doesn’t find that keyword, then mom goes about it’s normal business and will start up.

That seems reasonable. Just say so in the design.