# Pbs\_benchpress new option "skip-teardown" **URL:** \ **Category:** Developers\ **Created:** [July 3, 2018, 10:00pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067 "2018-07-03T22:00:59Z")\ **Posts on this page:** 20\ **Page:** 1
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 3, 2018, 10:00pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/1 "2018-07-03T22:00:59Z")
Hi, I was thinking about adding a new option to pbs\_benchpress called “skip-teardown”. I’ve been using “stop-on-failure” a lot, but I keep wanting it to not run teardown so that the system is left in the state right after the failure/error occurred, which is prefect for further debugging. What does the community think about adding a new option? If I get no thumbs down then I’ll consider it an approval 🙂 Thanks. ---
**Author:** ![mkaro](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/mkaro/32/85_2.png) [@mkaro](https://community.openpbs.org/u/mkaro)\ **Post date:** [July 3, 2018, 11:01pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/2 "2018-07-03T23:01:35Z")
I’ve also wanted something like this, but more like “abort-on-failure” that would both skip the tear down and stop running tests when a failure is encountered so we can investigate the state of things. I think you may also need a “teardown-only” option you can run after you’re done investigating, but perhaps not. ---
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 3, 2018, 11:17pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/3 "2018-07-03T23:17:38Z")
Thanks for your inputs Mike. Initially I felt that “stop-on-failure” should also skip teardown, but there might be cases where that’s not desirable. But if everyone feels that “stop-on-failure” should also do “skip-teardown”, then we can just enhance “stop-on-failure” instead of adding a new option. About “teardown-only”, I can see how that would help, but I haven’t felt the need for it personally. For now, I overwrite tearDown() to not do anything and that accomplishes “skip-teardown”, then I manually investigate what’s happening, fix my test or the code, and just run the test again and that cleans up the crud that was left behind earlier. ---
**Author:** ![anamika](https://avatars.discourse-cdn.com/v4/letter/a/67e7ee/32.png) [@anamika](https://community.openpbs.org/u/anamika)\ **Post date:** [July 4, 2018, 5:30am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/4 "2018-07-04T05:30:05Z")
Thanks Ravi. I like the idea of skip-teardown. And I would vote for keeping it separate than stop-on-failure. ---
**Author:** ![arungrover](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/arungrover/32/40_2.png) [@arungrover](https://community.openpbs.org/u/arungrover)\ **Post date:** [July 5, 2018, 4:44pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/5 "2018-07-05T16:44:36Z")
I think stop-on-failure should also skip teardown to help in debugging and keeping options simple. Anamika in which case will it help if we have these options separate? ---
**Author:** ![anamika](https://avatars.discourse-cdn.com/v4/letter/a/67e7ee/32.png) [@anamika](https://community.openpbs.org/u/anamika)\ **Post date:** [July 5, 2018, 8:24pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/6 "2018-07-05T20:24:03Z")
Hey @arungrover, it is helpful for the cases where part of the tests has to be run manually so you would want to preserve the setup. Also it was once discussed in the client meeting where they want to run some tests in production but with setUp and (specially) teardown off. I think I was not clear enough. Here is what I would like to see. - stop-on-failure by default skip tearDown - a separate option to skip-tearDown ---
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 5, 2018, 11:41pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/7 "2018-07-05T23:41:33Z")
Thanks for the explanation Anamika. I also agree that skip-teardown might have value by itself. But I am not sure if stop-on-failure _without_ skip-teardown has any value or not. So, what if we added a new option “skip-teardown” and also enhanced “stop-on-failure” to skip teardown by default? Can you think of a case where the latter would be undesirable? ---
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 5, 2018, 11:42pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/8 "2018-07-05T23:42:10Z")
Ok I apologize, that’s exactly what you suggested, so I guess that’s the right way to go. ---
**Author:** ![kjakkali](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/kjakkali/32/138_2.png) [@kjakkali](https://community.openpbs.org/u/kjakkali)\ **Post date:** [July 6, 2018, 2:45am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/9 "2018-07-06T02:45:36Z")
I think “stop-on-failure” should skip teardown. This will help in debugging and will be more widely used scenario. pbs\_benchpress’s -p option has ‘skip-teardown’ we should make use of this instead of adding direct option to pbs\_benchpress. ---
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 10, 2018, 10:32pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/10 "2018-07-10T22:32:30Z")
> [@kjakkali](#): > > pbs\_benchpress’s -p option has ‘skip-teardown’ we should make use of this instead of adding direct option to pbs\_benchpress. hmm, I personally think that skip-teardown should be a direct option to pbs\_benchpress, I can see it being more frequently used than some of the other direct options to pbs\_benchpress (especially since we are talking about moving most of the actual teardown to tearDown instead of setUp in the future). But I’ll go with consensus, @arungrover and @anamika, do you guys have any opinion on this? ---
**Author:** ![anamika](https://avatars.discourse-cdn.com/v4/letter/a/67e7ee/32.png) [@anamika](https://community.openpbs.org/u/anamika)\ **Post date:** [July 10, 2018, 11:11pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/11 "2018-07-10T23:11:19Z")
Hi @agrawalravi90 and @kjakkali, I don’t have any preference as long as it satisfies all the requirements. I am just worried that -p options are mostly unknown and over loaded which is different. ---
**Author:** ![bhroam](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/bhroam/32/20_2.png) [@bhroam](https://community.openpbs.org/u/bhroam)\ **Post date:** [July 11, 2018, 12:16am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/12 "2018-07-11T00:16:10Z")
If we have a skip-teardown, should we also have the opposite? skip-setup? ---
**Author:** ![agrawalravi90](https://avatars.discourse-cdn.com/v4/letter/a/848f3c/32.png) [@agrawalravi90](https://community.openpbs.org/u/agrawalravi90)\ **Post date:** [July 11, 2018, 12:56am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/13 "2018-07-11T00:56:18Z")
Interesting thought … I can’t think of a use case though … But it does seems to go hand in hand with skip teardown … ---
**Author:** ![kjakkali](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/kjakkali/32/138_2.png) [@kjakkali](https://community.openpbs.org/u/kjakkali)\ **Post date:** [July 11, 2018, 8:52am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/14 "2018-07-11T08:52:21Z")
@bhroam : Yes.pbs\_benchpress’s -p option has ‘skip-setup’ option. ---
**Author:** ![arungrover](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/arungrover/32/40_2.png) [@arungrover](https://community.openpbs.org/u/arungrover)\ **Post date:** [July 30, 2018, 9:42pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/15 "2018-07-30T21:42:36Z")
Hey @agrawalravi90, I would prefer if we reuse the existing option itself, especially when we also expose ski-setup using the same option. It will keep things consistent. That being said, we also need to improve on documenting all the options that can be given with ‘-p’ (at the very least pbs\_benchpress’s usage should talk about these options) ---
**Author:** ![kjakkali](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/kjakkali/32/138_2.png) [@kjakkali](https://community.openpbs.org/u/kjakkali)\ **Post date:** [August 1, 2018, 4:44am UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/16 "2018-08-01T04:44:20Z")
@arungrover : Anne is updating pbs\_benchpress command doc page. link :[https://pbspro.atlassian.net/wiki/spaces/DG/pages/504627244/Using+pbs+benchpress+under+construction?focusedCommentId=567607380#comment-567607380](https://pbspro.atlassian.net/wiki/spaces/DG/pages/504627244/Using+pbs+benchpress+under+construction?focusedCommentId=567607380#comment-567607380) ---
**Author:** ![arungrover](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/arungrover/32/40_2.png) [@arungrover](https://community.openpbs.org/u/arungrover)\ **Post date:** [August 1, 2018, 4:41pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/17 "2018-08-01T16:41:05Z")
Thanks for the pointer Kumar. This document will be really helpful to know what options can be passed to benchpress command. But, I also think we should update command’s usage because not everyone will go and look for the document on confluence. In case of commands it is really handy either to have an extensive usage or a man page. ---
**Author:** ![agurban](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/agurban/32/67_2.png) [@agurban](https://community.openpbs.org/u/agurban)\ **Post date:** [August 1, 2018, 6:06pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/18 "2018-08-01T18:06:15Z")
Should this command become supported, with a man page? ---
**Author:** ![arungrover](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/arungrover/32/40_2.png) [@arungrover](https://community.openpbs.org/u/arungrover)\ **Post date:** [August 3, 2018, 5:47pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/19 "2018-08-03T17:47:29Z")
I’m not sure about having it supported, but a man page would be helpful ---
**Author:** ![agurban](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/agurban/32/67_2.png) [@agurban](https://community.openpbs.org/u/agurban)\ **Post date:** [August 3, 2018, 6:12pm UTC](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067/20 "2018-08-03T18:12:14Z")
Here’s something you can use: [https://pbspro.atlassian.net/wiki/spaces/DG/pages/504627244/Using+pbs+benchpress+under+construction](https://pbspro.atlassian.net/wiki/spaces/DG/pages/504627244/Using+pbs+benchpress+under+construction) Please feel free to help make it better. [Next page](https://community.openpbs.org/t/pbs-benchpress-new-option-skip-teardown/1067.md?page=2)