# PP-706: Automatically create KNL specific information

**URL:** <https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678>\
**Category:** Developers\
**Created:** [September 20, 2017, 11:12am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678 "2017-09-20T11:12:47Z")\
**Posts on this page:** 17\
**Page:** 2

<div class="post-metadata">

**Author:** ![dilip-krishnan](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/dilip-krishnan/32/75_2.png) [@dilip-krishnan](https://community.openpbs.org/u/dilip-krishnan)\
**Post date:** [February 15, 2018, 7:34am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/21 "2018-02-15T07:34:16Z")

</div>

Hi @scc,  
But I guess there are plenty of ways to avoid such scenario. Like node priority, associating queues with knl and non-knl nodes and using node sort formula with custom resource.

Warm regards  
Dilip

---

<div class="post-metadata">

**Author:** ![scc](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/scc/32/234_2.png) [@scc](https://community.openpbs.org/u/scc)\
**Post date:** [February 16, 2018, 3:07pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/22 "2018-02-16T15:07:07Z")

</div>

No, I think it is OK to proceed with the proposal, I was just highlighting it as a pretty major difference in the two approaches. Thanks!

---

<div class="post-metadata">

**Author:** ![scott](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/scott/32/30_2.png) [@scott](https://community.openpbs.org/u/scott)\
**Post date:** [February 16, 2018, 3:22pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/23 "2018-02-16T15:22:03Z")

</div>

> [@scc](#):
>
> I was just highlighting it as a pretty major difference in the two approaches.

Yes, these are differences in behavior, but PBS has the means for an admin to “classify” a node by using node attributes. I know that Cray customers have been using vntype attribute to define “roles” for their nodes. This allows the users to submit jobs with vntype=cray\_serial or vntype=blue

For those sites upgrading, the vntype attribute will carryover. Those that are installing for the first time will use the PBS way of configuring the node attributes.

---

<div class="post-metadata">

**Author:** ![smgoosen](https://avatars.discourse-cdn.com/v4/letter/s/53a042/32.png) [@smgoosen](https://community.openpbs.org/u/smgoosen)\
**Post date:** [March 8, 2018, 6:43am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/24 "2018-03-08T06:43:49Z")

</div>

Changes to the design re: mention of the provisioning look promising. Based on suggestions above perhaps we should rename the hook script “PBS\_xeon\_phi\_ provision”.

---

<div class="post-metadata">

**Author:** ![riyazhakki](https://avatars.discourse-cdn.com/v4/letter/r/ba9def/32.png) [@riyazhakki](https://community.openpbs.org/u/riyazhakki)\
**Post date:** [March 12, 2018, 9:02am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/25 "2018-03-12T09:02:55Z")

</div>

> [@smgoosen](#):
>
> PBS\_xeon\_phi\_ provision

Hi Sam,  
Thank you for the comment.  
I have addressed your comment and added more details to the interface,  
please review the design document and provide comment / sign off.

---

<div class="post-metadata">

**Author:** ![riyazhakki](https://avatars.discourse-cdn.com/v4/letter/r/ba9def/32.png) [@riyazhakki](https://community.openpbs.org/u/riyazhakki)\
**Post date:** [March 12, 2018, 9:14am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/26 "2018-03-12T09:14:57Z")

</div>

Hi All,

I have updated the [design document](https://pbspro.atlassian.net/wiki/spaces/PD/pages/68780075/EDD+PP-706+Automatically+create+KNL+specific+information), added a new interface for the PBS provisioning hook and requesting you all to review and provide comment(s) / sign off.

Thanks, and regards  
Riyaz

---

<div class="post-metadata">

**Author:** ![Klovely](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/klovely/32/117_2.png) [@Klovely](https://community.openpbs.org/u/Klovely)\
**Post date:** [March 13, 2018, 10:06am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/27 "2018-03-13T10:06:30Z")

</div>

Latest changes done to the design looks good to me.

Regards,  
Lovely

---

<div class="post-metadata">

**Author:** ![smgoosen](https://avatars.discourse-cdn.com/v4/letter/s/53a042/32.png) [@smgoosen](https://community.openpbs.org/u/smgoosen)\
**Post date:** [March 13, 2018, 6:45pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/28 "2018-03-13T18:45:37Z")

</div>

Thanks for making the change, the design looks good to me!

---

<div class="post-metadata">

**Author:** ![lisa-altair](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/lisa-altair/32/643_2.png) [@lisa-altair](https://community.openpbs.org/u/lisa-altair)\
**Post date:** [March 14, 2018, 9:52pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/29 "2018-03-14T21:52:57Z")

</div>

Hi, I have a question about the PBS\_xeon\_phi\_provision hook. The design says:  
“This will be invoked whenever aoe resource is requested in the job.”

Is this true even when an assigned node has the requested aoe as the current aoe?  
Or will the hook check to see if the node is already set to what is requested, and thus not provision unnecessarily?

---

<div class="post-metadata">

**Author:** ![riyazhakki](https://avatars.discourse-cdn.com/v4/letter/r/ba9def/32.png) [@riyazhakki](https://community.openpbs.org/u/riyazhakki)\
**Post date:** [March 15, 2018, 11:25am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/30 "2018-03-15T11:25:00Z")

</div>

Hi Lisa,

Thanks for the review.  
If the node is already set to requested aoe as current aoe then provisioning hook will not be invoked.  
I have now updated the design document.

---

<div class="post-metadata">

**Author:** ![lisa-altair](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/lisa-altair/32/643_2.png) [@lisa-altair](https://community.openpbs.org/u/lisa-altair)\
**Post date:** [March 15, 2018, 11:34pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/31 "2018-03-15T23:34:55Z")

</div>

Hi @riyazhakki  
Good to know. Thank you for updating the design. I sign off.

---

<div class="post-metadata">

**Author:** ![lisa-altair](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/lisa-altair/32/643_2.png) [@lisa-altair](https://community.openpbs.org/u/lisa-altair)\
**Post date:** [March 19, 2018, 11:56pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/32 "2018-03-19T23:56:30Z")

</div>

Sorry, look like I have one more comment. I had made this comment in my code review, but since it pertains to the external design, I’ll also post my comment here.

In the code log messages #2 and #3 are actually logged at PBSEVENT\_DEBUG4. But the design doc says it should be PBSEVENT\_DEBUG2. Which is correct?

---

<div class="post-metadata">

**Author:** ![riyazhakki](https://avatars.discourse-cdn.com/v4/letter/r/ba9def/32.png) [@riyazhakki](https://community.openpbs.org/u/riyazhakki)\
**Post date:** [March 23, 2018, 10:08am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/33 "2018-03-23T10:08:53Z")

</div>

Hi Lisa,

I have updated the design document, where I made changes to log messages, debug levels on #2 and #3, and removed the #5 based on latest code changes during the review. Please review the document.

---

<div class="post-metadata">

**Author:** ![lisa-altair](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/lisa-altair/32/643_2.png) [@lisa-altair](https://community.openpbs.org/u/lisa-altair)\
**Post date:** [March 23, 2018, 4:07pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/34 "2018-03-23T16:07:55Z")

</div>

Thanks! The code and design now match! Looks good to me.

---

<div class="post-metadata">

**Author:** ![lisa-altair](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/lisa-altair/32/643_2.png) [@lisa-altair](https://community.openpbs.org/u/lisa-altair)\
**Post date:** [March 28, 2018, 11:27pm UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/35 "2018-03-28T23:27:21Z")

</div>

I see that you have updated hbmem. Thanks for the new information.

---

<div class="post-metadata">

**Author:** ![Klovely](https://yyz2.discourse-cdn.com/flex030/user_avatar/community.openpbs.org/klovely/32/117_2.png) [@Klovely](https://community.openpbs.org/u/Klovely)\
**Post date:** [March 29, 2018, 6:42am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/36 "2018-03-29T06:42:37Z")

</div>

Thanks for making the change, the design looks good to me!

---

<div class="post-metadata">

**Author:** ![smgoosen](https://avatars.discourse-cdn.com/v4/letter/s/53a042/32.png) [@smgoosen](https://community.openpbs.org/u/smgoosen)\
**Post date:** [March 30, 2018, 5:29am UTC](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678/37 "2018-03-30T05:29:05Z")

</div>

Thank you for the quick turn around re: review and updates, the latest changes look good!

[Previous page](https://community.openpbs.org/t/pp-706-automatically-create-knl-specific-information/678.md?page=1)
