Using PTL_AND as default for expect function in PTL


currently server.expect uses PTL_OR as default for multiple attributes. But looking at most of the existing tests, they are looking for PTL_AND. (some of the tests do not have attrop set but they should as they are expecting all attributes to be set). Should we just make PTL_AND as default instead inside expect for multiple attributes?

I think it is more intuitive that if you pass multiple attributes to expect() that you expect both of them to be matched. I think the default should be changed to PTL_AND.


1 Like

I agree, default behavior of checking for multiple attributes should be an AND operator.

Thanks @arungrover and @bhroam. I have filed PP-1290 for tracking this change request.